[DISCUSSION] Downsampling Aliasing

Open
#470 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
15/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp

Research direction

Start by reading the linked TheGearPage post and then locate the plugin's downsampling implementation. The issue names no files, tests, reproduction steps, or acceptance criteria; work is not complete until the aliasing concern and a concrete validation approach are agreed.

Written by the indexing model from the issue text.

Description

bug priority:low unread

Since there is no discussion section I post it as an issue. The following post over at TheGearPage demonstrates aliasing issues with the downsampling: https://www.thegearpage.net/board/index.php?threads/nam-experiment-minimizing-aliasing-maximizing-accuracy-to-cpu-efficiency-ratio-poll.2559009/post-38914289

Maybe it is of interest. Regards.

Dominant language
C++
Stars
3k
Forks
281
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sdatkinson/NeuralAmpModelerPlugin

All issues in sdatkinson/NeuralAmpModelerPlugin

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.