[FEATURE] Use native resampling on NAMs that support it.

Open
#681 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
audio-video-rtc

Research direction

Start by reviewing PR #333 and tracing the model and ResamplingNAM entry points it introduced or affects. Determine how arbitrary sample-rate support is exposed, then verify that native-capable models bypass ResamplingNAM while other models retain it; add or update focused tests for both paths.

Written by the indexing model from the issue text.

Description

enhancement priority:low

https://github.com/sdatkinson/NeuralAmpModelerCore/pull/333 adds support for NAMs whose sample rate can be adjusted arbitrarily.

For such models, there is no need to use the resampling wrapper. This issue tracks asking the model whether it supports arbitrary sample rates, and only uses ResamplingNAM when false.

Dominant language
C++
Stars
3k
Forks
281
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sdatkinson/NeuralAmpModelerPlugin

All issues in sdatkinson/NeuralAmpModelerPlugin

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.