[FEATURE] IR Normalization on NAM plugin IR loader

Open
#313 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
audio-video-rtc

Research direction

Start by locating the NAM IR loader and reviewing how the example IRs are loaded and their output levels are handled. Compare the linked IRs and video behavior; done means IRs representing the same tone produce consistent output volume after loading.

Written by the indexing model from the issue text.

Description

enhancement priority:low

The IR loader on NAM does not normalize the output level of IRs. This causes some IRs to be very loud and others to be very quiet.

Demo video (unlisted):
https://youtu.be/xqpA6RBFz1U

Link to IRs used in video:
https://drive.google.com/file/d/14k9mRz8k2wqyYeyQPGwVkb1BNKTinwev/view?usp=drive_link

It would be great if the IR loader could be enhanced to normalize the IR that is loaded into it.
These are example IRs of the exact same tone, exported with different volumes.

If you load these IRs into any popular external IR loader (NadIR, MConvolutionEZ, etc) they will all have the same output volume. If you load them into NAM, they have different output volumes.

Additional context
This would prove very useful for a project I am working on that would allow me to very easily integrate JZIR into NAM where I would have 2 IRs in series. The first IR which would load into NAM would be the "eq correction" IR which would standardize the EQ output of every NAM profile (this IR is very quiet right now which is primarily why Im asking for this enhancement) then the 2nd IR would be loaded in an external IR loader and that would have the band/song/album tone. You can download my example workflow for possible NAM integration for JZIR here:
https://drive.google.com/file/d/12uLZNhOp3l4m8ACo_3FPx94SJWYKNGij/view?usp=drive_link

Dominant language
C++
Stars
3k
Forks
281
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sdatkinson/NeuralAmpModelerPlugin

All issues in sdatkinson/NeuralAmpModelerPlugin

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.