[FEATURE] There should be a pre-defined folder for nam/ir files (on macOS at least)

Open
#254 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, macos

Research direction

Review the macOS sandbox entitlements and the popup menu and navigation controls introduced in #242. Decide how the proposed Music/NeuralAmpModeler/Models and Impulses folders should be integrated; done means file loading and adjacent-file navigation work within the host app's sandbox constraints. No files or tests are named.

Written by the indexing model from the issue text.

Description

enhancement priority:low

Due to the macOS sandbox disk access is is limited to certain folders that are specified in an App's .entitlements files. For the standalone app, it's possible to specify these ourselves (there is a quite limited selection) see #250, but in a DAW they will be specified by the host app. It's common practice to store presets these days in the users "Music" folder with a subfolder for the product name.

I suggest using the folders ~/Music/NeuralAmpModeler/Models and ~/Music/NeuralAmpModeler/Impulses or similar.

Without this, the popupmenu and navigation controls that I added in #242 will fail if people try to load files outside the macOS sandbox, basically the menu will not be populated with adjacent files to the selected one, because all the posix file system APIs will fail outside the sandbox.

Dominant language
C++
Stars
3k
Forks
281
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sdatkinson/NeuralAmpModelerPlugin

All issues in sdatkinson/NeuralAmpModelerPlugin

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.