[FEATURE] Support Clang compilation

Open
#222 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp
Domain
build-system

Research direction

Start with the existing VS project and the release build process, then inspect how the plugin's current iPlug2 fork is integrated. Verify which later iPlug2 fixes are required for Clang compilation and define the release-build configuration that completes successfully without changing the default out-of-the-box VS path.

Written by the indexing model from the issue text.

Description

enhancement good first issue priority:low

My testing indicates that compiling with Clang gives a noticeable (on the order of 10%) speed improvement - likely because it optimizes the Eigen matrix code a bit better than the VS compiler.

It probably makes sense not to switch the VS project to Clang, since it will make it harder for people to compile out-of-the-box (most people won't have Clang installed). I think it can be specified in the release build process, though.

The only issues I encountered with building the plugin with Clang were a couple of minor iPlug2 things that seem to have already been fixed - but in a later version of iPlug2 than the fork the plugin is currently using.

Dominant language
C++
Stars
3k
Forks
281
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sdatkinson/NeuralAmpModelerPlugin

All issues in sdatkinson/NeuralAmpModelerPlugin

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.