Feature request: Expose A2 Slimmable module metdata to clients.

Open
#263 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp

Research direction

Start by locating the DSP APIs and the slimmable model handling described in the issue. Determine where submodule metadata is represented, then expose the requested max_value data for clients and verify that it covers slimmed models, including values that may not be in the top-level container.

Written by the indexing model from the issue text.

Description

A low-priority feature request:

Pipedal running a Raspberry Pi 4 could make good use of slimmed models, given that in can only run two NAM instances easily. It would therefore be a nice feature if TooB Neural Amp Modeler could provide a dropdown in it's user-interface that allows selection of Full, or Light, or Pico &c models.

If the module metadata were exposed in DSP APIs, I could add a UI component to TooB Neural Amp Modeller that allows selection of slimmed models, if present in the model file.

Data I would need: a vector of doubles containing max_value metadata for each submodule in a slimmable model. (Or an enumeration of 'max_value' values in the entire DSP tree, I suppose. :-/

Failing that, I guess I could pre-load the config file and extract values out of the json model, although I'm guessing that slimmable parameters might be present elsewhere in the model than just the top-level slimmable container model.

Dominant language
C++
Stars
931
Forks
178
Avg merge
3h 31m
Merged PRs (30d)
7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sdatkinson/NeuralAmpModelerCore

All issues in sdatkinson/NeuralAmpModelerCore

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.