[BUG] Loading certain A1 models after A2 models can cause audio crackling / dropouts

Open
#303 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp

Research direction

Start by reproducing the audio crackling in Gateway with the supplied Models used on video.zip, loading the A1 models after the A2 models. Then inspect the NAM Core model-loading and prepareToPlay path, since re-instantiating the plugin currently resolves the issue. Done means the affected A1 models play correctly without requiring re-instantiation.

Written by the indexing model from the issue text.

Description

Hi,

we discovered a hard-to-reproduce issue, where certain A1 models will not play correctly when loaded right after certain other A2 models. Re-instantiating the plugin (prepareToPlay call) will resolve the issue.

We discovered this on our own implementation of the NAM Core (which uses none of the Gateway plugin harness), and verified it on Gateway, which leads us to believe the issue lies with the NAM Core itself.

See the following video reproducing the issue on Gateway.
https://github.com/user-attachments/assets/e36ccd2e-7875-4f88-9366-a179ecb721d2

Additionally you can find Models used on video.zip here.

Please let me know if you need any additional information.

Dominant language
C++
Stars
931
Forks
178
Avg merge
3h 31m
Merged PRs (30d)
7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sdatkinson/NeuralAmpModelerCore

All issues in sdatkinson/NeuralAmpModelerCore

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.