[PERFORMANCE] Grouped convolutions appear dominated by overhead

Open
#215 0 comments 0 reactions 1 assignee View on GitHub

@sdatkinson is already working on this.

Since Jan 29, 2026.

Assessment

This issue has not been assessed yet.

Description

I'm profiling the models here and I'm getting poor results when grouped convolutions are used.

For example, 1x1_groups looks at scaling upt he number of groups in an 8-channel 1x1:

Image

This plot makes it look like the overhead is what's dominating the calculation since the compute time scales linearly with the number of groups.

This is bad because it means that grouped convolutions are basically useless--better to just use the full matrix with a ton of zeroes.

I suspect that compile-time optimizations may solve this, but I'm surprised that it's this bad.

Dominant language
C++
Stars
931
Forks
178
Avg merge
3h 31m
Merged PRs (30d)
7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sdatkinson/NeuralAmpModelerCore

All issues in sdatkinson/NeuralAmpModelerCore

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.