[BREAKING] Remove `Buffer` DSP class

Open
#186 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
audio-video-rtc

Research direction

Start with the Buffer definition in NAM/dsp.h at the linked location, then search the repository for references to understand the breaking change's scope. Done means the unused class and any necessary references are removed while the C++ library still builds.

Written by the indexing model from the issue text.

Description

breaking

I don't think this class is needed.

https://github.com/sdatkinson/NeuralAmpModelerCore/blob/8031a06596c1db8bdfb61c4f5e2f9b0e2b09d2ef/NAM/dsp.h#L132

Dominant language
C++
Stars
931
Forks
178
Avg merge
3h 31m
Merged PRs (30d)
7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sdatkinson/NeuralAmpModelerCore

All issues in sdatkinson/NeuralAmpModelerCore

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.