ros-perception / ros-perception/image_common

qos overriding support for republish.cpp on humble

Open
#378 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
153
Forks
253
Avg merge
5m
Merged PRs (30d)
1

Description

republish.cpp on humble doesn't support qos overriding on input and output topics when used in cli.

ros2 run image_transport republish compressed raw \
 --ros-args -r in/compressed:=/camera1/image_compressed \
 -r out:=/camera1/uncompressed

https://github.com/ros-perception/image_common/blob/5e4dd9ed2daae23a6d06ff98e0a5bef19a9314da/image_transport/src/republish.cpp#L64

https://github.com/ros-perception/image_common/blob/5e4dd9ed2daae23a6d06ff98e0a5bef19a9314da/image_transport/src/republish.cpp#L71-L73

The rolling branch has a completely different implementation of republish.cpp - i was curious if it would be possible to backport?

if a backport would break image_common - would it be okay to make a configurable rmw_qos_profile_t struct for configuration when vargv.size() < 3 and set image_transport::create_subscription() and image_transport::create_publisher(). Would this be reasonable?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in image_transport/src/republish.cpp at the referenced lines and compare the rolling branch's republish.cpp implementation. Verify how the Humble CLI creates the input subscription and output publisher, then confirm that QoS overrides work for both topics without breaking image_common compatibility.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
robotics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.