redhat-developer / redhat-developer/vscode-java

Refactoring extraction methods leads to inconsistent code behavior

Open
#3,592 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

potential-duplicate
Dominant language
TypeScript
Stars
2.3k
Forks
546
Avg merge
20h 1m
Merged PRs (30d)
11

Description

[provide a description of the issue]

Environment

Operating System: Windows11
JDK version: 17
Visual Studio Code version: 1.88
Java extension version: 1.29

Steps To Reproduce
  1. select "switch (value) {...return result;"
  2. click “Refacator-Extract to method”

class ExtractMethodTest {
private final int value;

public ExtractMethodTest(int value) {
this.value = value;
}

public synchronized int calculate() {
int result;
// extract method
switch (value) {
case 1:
result = value * 2;
break;
case 2:
result = value * 3;
break;
default:
result = value * 4;
break;
}
return result;
// end
}
}

refactoring result:
image

Reason: Local variables have been added to the extraction method, and if the inline method refactoring is performed, it will not match the behavior of the original code

Expected behavior: Check before and after refactoring and provide warning prompts

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the report. Reproduce the Extract to method case on Windows 11 with JDK 17, then compare the original, extracted, and inline-refactored behavior. Done means inconsistent behavior is detected and an appropriate warning is shown before or after refactoring.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, vscode
Domain
devtools
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.