HTTP server: Persistent connection on HTTP/1.0 hangs, when using streaming response body

Abierto
#552 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
76/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Tranquilo
Stack tecnológico
php
Área
api, backend

Línea de trabajo

Start at src/Io/StreamingServer.php around line 308 and reproduce the issue with the provided streaming ThroughStream example and curl --http1.0 request. Trace how an HTTP/1.0 response with an unknown body size handles Connection: keep-alive; done means the response is transmitted and the connection closes instead of hanging.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Assuming the response body is streaming and its size is unknown, when a request such as this is received:

GET / HTTP/1.0
Connection: keep-alive

ReactPHP produces a response without a Content-Length header, such as this:

HTTP/1.0 200 OK
Connection: keep-alive

<data>

and doesn't close the connection, which then just hangs until timeout, because for the client there is no way of telling, when the response data is finished transmitting.

Steps to reproduce:

$server = new React\Http\HttpServer(function () {
    $stream = new ThroughStream();
    Loop::futureTick(function () use ($stream) {
        $stream->write("foo\n");
        $stream->end();
    });
    return new Response(200, body: $stream);
});

$socket = new React\Socket\SocketServer("0.0.0.0:80");
$server->listen($socket);

curl -v --http1.0 -H "connection: keep-alive" localhost:80

Tested on v1.11.0 and 3.x-dev (4e1b4f369eea9428ac38b8851e113ce5ad47cbee).

Since it's HTTP/1.0, Transfer-Encoding: chunked cannot be used. I believe the only good way to handle this situation is to ignore the requested Connection: keep-alive and just close the connection after the response is transmitted. I think this should be a valid behavior - server is not required to strictly obey the keep-alive request header.

The relevant code is here: https://github.com/reactphp/http/blob/1.x/src/Io/StreamingServer.php#L308

Lenguaje dominante
PHP
Estrellas
781
Forks
166
Sin PR fusionados en 30 d

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de reactphp/http

Todos los issues de reactphp/http

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.