[Suggestion]: The process of commit phase is not clear.
還沒有人認領這個 Issue。
- 主要語言
- JavaScript
- 星號
- 11.8k
- 分支
- 7.9k
- 平均合併
- 1 天 11 小時
- 30 天內合併 PR
- 11
描述
Summary
A more detailed explanation between the process of commit phase and Browser paint. And
Page
https://react.dev/learn/render-and-commit#step-3-react-commits-changes-to-the-dom
Details
At the end of this section, it summrize that Any screen update in a React app happens in three steps:Trigger, Render and Commit, but this section is actually divided into four subsections
- Step 1: Trigger a render
- Step 2: React renders your components
- Step 3: React commits changes to the DOM
- Epilogue: Browser paint
I can't figure out if the process of commit phases include Browser paint. In the Synchronizing with Effects section, it mentions that Effect will run after every commit. I think including browser paint into the process of commit phase is expected, and it would make sense to cut down this section into just three subsections, including browser paint into submit subsection.
Also in the Synchronizing with Effects section, there are two sentences like so:
Effects run at the end of a commit after the screen updates.
By default, your Effect will run after every commit.
I am not a English navitive speaker, and I think at the end of and after have different meaning, at the end of show something happens in the process of commit , while after doesn't. It would make sense to change at the end of to another phrase.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從「Render and commit」頁面開始,特別查看第 3 步和「Browser paint」結語,接著將其中的術語與「Synchronizing with Effects」進行比較。當文件明確區分 commit 和 browser paint,並解決「at the end of」與「after」之間表述不一致的問題時,即可視為完成。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- javascript, react
- 領域
- documentation
- Issue 類型
- 文件
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100