[Suggestion]: The process of commit phase is not clear.
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- JavaScript
- Estrellas
- 11.8k
- Forks
- 7.9k
- Merge medio
- 1 d 11 h
- PR fusionados (30 d)
- 11
Descripción
Summary
A more detailed explanation between the process of commit phase and Browser paint. And
Page
https://react.dev/learn/render-and-commit#step-3-react-commits-changes-to-the-dom
Details
At the end of this section, it summrize that Any screen update in a React app happens in three steps:Trigger, Render and Commit, but this section is actually divided into four subsections
- Step 1: Trigger a render
- Step 2: React renders your components
- Step 3: React commits changes to the DOM
- Epilogue: Browser paint
I can't figure out if the process of commit phases include Browser paint. In the Synchronizing with Effects section, it mentions that Effect will run after every commit. I think including browser paint into the process of commit phase is expected, and it would make sense to cut down this section into just three subsections, including browser paint into submit subsection.
Also in the Synchronizing with Effects section, there are two sentences like so:
Effects run at the end of a commit after the screen updates.
By default, your Effect will run after every commit.
I am not a English navitive speaker, and I think at the end of and after have different meaning, at the end of show something happens in the process of commit , while after doesn't. It would make sense to change at the end of to another phrase.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza por la página “Render and commit”, especialmente por el paso 3 y el epílogo “Browser paint”, y después compara su terminología con “Synchronizing with Effects”. Se considera terminado cuando la documentación distingue claramente entre commit y browser paint y resuelve la redacción incoherente entre “at the end of” y “after”.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript, react
- Área
- documentation
- Tipo de issue
- Documentación
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 45/100