[Suggestion]: StrictMode confusion about ordering of the events
まだ誰も着手していません。
- 主要言語
- JavaScript
- スター
- 11.8k
- フォーク
- 7.9k
- 平均マージ
- 1日 11時間
- マージ済み PR(30日)
- 11
説明
Summary
This thread comes really close to avoid repeating this question again.
However I still have some doubts about the chain of the events in the strict mode.
I will quote the answer which provide the most valuable feedback.
"The mental model for this is that React really does unmount the component, but when re-mounting the component we restore the previously used state instead of starting fresh, the way Fast Refresh does, or some future features will."
But if that's the case why the order of the events(rendering, setting state, effects etc) is different while running in strict mode and outside of it?
Here are the concrete examples:
- https://codesandbox.io/p/sandbox/2z4wq2. This sandbox runs inside a strict mode and by inspecting the console we can see that the order of the events is like this
render
state setter
render
state setter
effect
clean up
effect
The second render and state setter are dimmed out according to the documentation and that's fine. So at least on the surface it appears that react is triggering render function (and state setter) 2 times before moving to the effects.
- https://codesandbox.io/p/sandbox/93zfkw. This sandbox runs outside of the strict mode and there is a button to toggle the mounting of the component. If the component is mounted, unmounted and mounted again the order of the events is like this.
render
state setter
effect
clean up
render
state setter
effect
This example has the mental model I have always worked with and which is clear, so I would waste too much time on it since that's how React also behaves on production.
The question is, if react is really performing mounting, unmounting and remounting while is the order different?
To be honest I haven't noticed that this difference is making my code harder to reason about while working with StrictMode.
I would like to know the details, if possible. What does this approach help React achieve that original one does not?
Page
https://react.dev/reference/react/StrictMode
Details
I think it would be helpful to update the page to explain why the behavior in StrictMode is different than simply running mounting, unmounting and mounting again.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
React StrictModeのリファレンスページから始め、現在の説明を、リンクされているissueスレッドおよび2つのCodeSandboxの例と比較してください。StrictModeで観測されるrender、state、effect、cleanupの順序が、独立したmount-unmount-remountサイクルと異なる理由を明確にし、その違いに説明が答えるようにページを更新してください。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- javascript, react
- 領域
- documentation
- issue の種類
- ドキュメント
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100