useCallback vs useRef misguidance (confounding useRef with object ref)
まだ誰も着手していません。
- 主要言語
- JavaScript
- スター
- 11.8k
- フォーク
- 7.9k
- 平均マージ
- 1日 11時間
- マージ済み PR(30日)
- 11
説明
The Proposal
As part of a deductive exercise, in this issue I essentially proposed changing:
x = useCallback(cb , []);
To:
x = useRef(cb).current;
With useRef:
- No deps comparison (
Object.is). - No reallocation of empty array on each render.
These optimisations are terribly minute, but understanding React is what at stake here.
The Question
Then the reply came:
Is there ever a situation where a dependency-less useMemo or useCallback would be a better choice than useRef?
The Docs
I couldn't think of one, so posted an SO question, for which a reply came with reference to these docs:
We didn't choose useRef in this example because an object ref doesn't notify us about changes to the current ref value. Using a callback ref ensures that even if a child component displays the measured node later (e.g. in response to a click), we still get notified about it in the parent component and can update the measurements.
In the codesandbox example provided, we see useCallback with empty dependencies:
const measureRef = useCallback(node => {
if (node !== null) {
setHeight(node.getBoundingClientRect().height);
}
}, []);
Yet changing the useCallback above to useRef(cb).current works all the same:
const measureRef = useRef(node => {
if (node !== null) {
setHeight(node.getBoundingClientRect().height);
}
}).current;
Misguidance?
Now I understand the docs focus on a callback ref, so using useCallback makes sense.
But this statement is misleading:
We didn't choose
useRefin this example because an object ref...
First, it promotes the (in my view somewhat popular) misconception that useRef is solely there to refer to DOM elements (filled via object ref).
Further, this statement confounds useRef with object ref:
- object ref vs callback ref is one thing
useRefis another.
What useRef is Really for
Far from this, useRef raison d'être is the ability to create stable values; callbacks are no exception:
const stableCallback = useRef(()=> { ... }).current;
Storing DOM elements is a popular, yet a specific use case for refs.
Another Example
From the docs:
Keep in mind that useRef doesn’t notify you when its content changes. Mutating the .current property doesn’t cause a re-render. If you want to run some code when React attaches or detaches a ref to a DOM node, you may want to use a callback ref instead.
I argue that this statement distorts people's understanding of core React concept. It builds a mental model where there is such 'cosmic' mapping:
useRef→ object refuseCallback→ callback ref
This is incorrect.
(Nitpickers, like me, will point out at this point that both "object ref" and "callback ref" have "ref" in them!)
What needs changing?
First, useRef should not be part of this sentence:
We didn't choose
useRefin this example because an object ref...
Instead:
We didn't use an object ref as it doesn't notify...
Also this:
Keep in mind that useRef doesn’t notify you when its content changes...
To this:
Keep in mind that object refs don't notify you when its content changes...
Then, if useRef(cb).current is identical to (and slightly more efficient than) useCallback(cb, []), perhaps this is something worth mentioning?
More generally, if correct, I would expect to see this somewhere in the docs:
useMemo(x, [])anduseCallback(cb, [])are the identical touseRef(x).currentanduseRef(cb).currentrespectively.
Learning this is conceptually important, thus so is teaching.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
参照されている hooks-faq.md と hooks-reference.md のセクションから始め、issue で提案されている文言と併せて callback-ref の例を確認してください。object refs、useRef、useMemo、useCallback に関する主張が正確かどうかを確認してから、どの用語または説明を変更すべきかを判断してください。完了とは、ドキュメントが技術的に正確で、違いが明確になっている状態です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- javascript, react
- 領域
- documentation
- issue の種類
- ドキュメント
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100