[Docs] React.cloneElement and forwarding ref
Ninguém assumiu esta issue ainda.
- Linguagem predominante
- JavaScript
- Estrelas
- 11.8k
- Forks
- 7.9k
- Merge médio
- 1d 11h
- PRs com merge (30d)
- 11
Descrição
Hi, I believe the documentation about React.cloneElement is not very clear about handling refs.
I am talking about that part: https://reactjs.org/docs/react-api.html#cloneelement
However, it also preserves refs. This means that if you get a child with a ref on it, you won’t accidentally steal it from your ancestor. You will get the same ref attached to your new element.
Now, let's see consider the following use case (simplified):
const ChangeTitle = ({ children, ...otherProps }) =>
React.cloneElement(children, {
...otherProps,
title: 'Title was changed'
})
function MyComponent() {
const myRef = React.useRef()
return (
<ChangeTitle ref={myRef}>
<span>This is my component</span>
</ChangeTitle>
)
}
This throws a console warning about ChangeTitle unable to hold a ref.
In my original understanding of the docs, I though ChangeTitle would become the cloned element, which, as the docs explains, retain it's original ref, hance the one given by Mycomponent.
Instead, this is obviously wrong, and the cloned element would only retain a ref if it was given to itself, not the parent component, hence something like <span ref={spanRef}>This is my component</span>.
I guess the fix to the above code is the following:
const ChangeTitle = React.forwardRef(({ children, ...otherProps }, ref) =>
React.cloneElement(children, {
...otherProps,
ref,
title: 'Title was changed'
}))
Correct?
Is it worth adding specifically that cloneElement can contain the ref prop if used with React.forwardRef in a functional component?
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Direção de pesquisa
Revise a seção da API React cloneElement vinculada no issue e compare a redação sobre ref com o exemplo ChangeTitle fornecido. Esclareça qual ref é mantido e como React.forwardRef pode passar um ref adiante; a tarefa estará concluída quando a explicação descrever com precisão o aviso e o uso corrigido.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- react
- Domínio
- documentation
- Tipo de issue
- Documentação
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Status de atividade
- Estagnada
- Clareza
- Razoavelmente clara
- Facilidade para iniciantes
- 48/100