[Android] ReactRootProjectPlugin drops :app:preBuild -> library preBuild dependency under --configure-on-demand, breaking codegen before CMake
まだ誰も着手していません。
- 主要言語
- C++
- スター
- 127k
- フォーク
- 25.3k
- 平均マージ
- 1日 23時間
- マージ済み PR(30日)
- 4
説明
Description
ReactRootProjectPlugin makes :app:preBuild depend on every library's preBuild so that library codegen runs before the app's CMake configure:
project.gradle.projectsEvaluated {
val appProject = project.rootProject.subprojects.find { it.name == "app" }
val appPreBuild = appProject?.tasks?.findByName("preBuild")
if (appPreBuild != null) {
val otherPreBuildTasks =
project.rootProject.subprojects
.filter { it != appProject }
.mapNotNull { it.tasks.findByName("preBuild") }
appPreBuild.dependsOn(otherPreBuildTasks)
}
}
When Gradle runs with --configure-on-demand (Expo CLI passes it unconditionally in expo run:android), a library project that has not been evaluated by the time projectsEvaluated fires has no preBuild task yet, so findByName returns null and the dependency is silently dropped. The app's configureCMake<Variant> then runs before that library's generateCodegenArtifactsFromSchema, and the autolinking CMake file fails with:
CMake Error at android/app/build/generated/autolinking/src/main/jni/Android-autolinking.cmake:19 (add_subdirectory):
add_subdirectory given source
".../node_modules/react-native-sherpa-onnx/android/build/generated/source/codegen/jni/"
which is not an existing directory.
CMake Error at .../ReactAndroid/cmake-utils/ReactNative-application.cmake:97 (target_link_libraries):
Cannot specify link libraries for target "react_codegen_SherpaOnnxSpec"
which is not built by this project.
Which libraries are affected depends on evaluation order, so it looks flaky per project. In my project @stripe/stripe-react-native (also a codegen TurboModule library) happened to be evaluated in time and worked, while react-native-sherpa-onnx was not. The same failure was reported independently against that library (XDcobra/react-native-sherpa-onnx#63) and closed as not reproducible, which fits an ordering-dependent bug.
Running the identical build without --configure-on-demand (./gradlew :app:assembleDebug -PreactNativeArchitectures=arm64-v8a) succeeds; the task log shows :react-native-sherpa-onnx:generateCodegenArtifactsFromSchema → :app:preBuild → :app:configureCMakeDebug[arm64-v8a].
Workaround (verified): in the app's build.gradle, add an explicit task-path dependency, which forces on-demand configuration of that project:
preBuild.dependsOn(':react-native-sherpa-onnx:preBuild')
A robust fix would be to wire the dependency per subproject as each one is evaluated (e.g. subproject.afterEvaluate { appPreBuild.dependsOn(subproject.tasks.named("preBuild")) }, or dependsOn("${subproject.path}:preBuild") by task path) instead of snapshotting subprojects at projectsEvaluated.
Steps to reproduce
npx create-expo-app repro && cd repronpx expo install react-native-sherpa-onnx @dr.pogodin/react-native-fs(any third-party library withcodegenConfigand a JNI target that Gradle happens to evaluate late)npx expo run:android(Expo CLI runs Gradle with--configure-on-demand)- Build fails in
:app:configureCMakeDebug[<abi>]as above. cd android && ./gradlew :app:assembleDebugsucceeds.
React Native Version
0.86.0
Affected Platforms
Build - Android
Output of npx @react-native-community/cli info
System:
OS: macOS 26.6.2
CPU: (14) arm64 Apple M4 Pro
Binaries:
Node: 24.12.0
npm: 11.6.2
Watchman: Not Found
Managers:
CocoaPods: 1.17.0
IDEs:
Android Studio: 2025.3
Xcode: 26.2/17C52
Languages:
Java: 17.0.12
Expo SDK 57 (expo 57.0.8), Gradle 9.3.1, AGP as shipped with RN 0.86.0, NDK 27.1.12297006, CMake 3.22.1
Stacktrace or Logs
> Task :stripe_stripe-react-native:generateCodegenArtifactsFromSchema
> Task :app:preBuild
...
> Task :react-native-sherpa-onnx:downloadNativeLibsIfNeeded
> Task :app:configureCMakeDebug[arm64-v8a] FAILED
(no :react-native-sherpa-onnx:generateCodegenArtifactsFromSchema before the failure)
Execution failed for task ':app:configureCMakeDebug[arm64-v8a]'.
> [CXX1429] error when building with cmake using .../ReactAndroid/cmake-utils/default-app-setup/CMakeLists.txt
CMake Error at .../Android-autolinking.cmake:19 (add_subdirectory):
add_subdirectory given source ".../react-native-sherpa-onnx/android/build/generated/source/codegen/jni/" which is not an existing directory.
MANDATORY Reproducer
Steps above (create-expo-app + react-native-sherpa-onnx + expo run:android). The failure depends on Gradle's on-demand evaluation order, so the library that gets skipped may differ by project.
Screenshots and Videos
N/A
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
まず ReactRootProjectPlugin を見つけ、projectsEvaluated がライブラリの preBuild タスクをどのように検出するかを追跡します。Expo と react-native-sherpa-onnx の必須手順で再現し、その後、--configure-on-demand を指定した場合と通常の場合の Gradle タスクの順序を比較します。ライブラリの codegen が app configureCMake より前に実行され、autolinking の CMake 生成が成功すれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- android, cmake, kotlin, react-native
- 領域
- build-system, mobile
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 活発
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 55/100