iOS Fabric: `display: none` silently destroys host-component, instead of just hiding or removing it
まだ誰も着手していません。
- 主要言語
- C++
- スター
- 127k
- フォーク
- 25.3k
- 平均マージ
- 1日 23時間
- マージ済み PR(30日)
- 4
説明
Description
Hi, Ioannis here from Margelo.
While migrating a client's app to the new architecture, we noticed that on iOS fabric, whenever a fabric component under Suspense get's suspended (thus display:none was set), our native view components were unmounted (removed and deleted - not just hidden but actually deallocated) and that resulted on their state being lost.
This seems to be a change in behavior to the old arch, where display: none would merely hide the view.
I did a poll among my RN colleagues, and no one expected that the view would be deleted on display: none especially given that you apply that style with the intention to bring the view back after a moment.
Furthermore, the behavior is what we'd expect on Android, where fabric choses to just hide the views (setVisibility(GONE)).
I was wondered if this was added intentionally back then? If so, I think i'd prefer to have a way to either opt-in/out of this behavior (see my PR).
Steps to reproduce
- Clone https://github.com/SudoPlz/reproducer-react-native
cd ReproducerApp && yarn install && cd ios && pod install && cd ..yarn ios- Tap "Set red" → red. Tap "Toggle display" off → gone. Tap "Toggle display" on → reappears WHITE (Command-set state lost).
- Notice
deallocbeing called
React Native Version
0.85.2
Affected Platforms
Runtime - iOS
Output of npx @react-native-community/cli info
System:
OS: macOS 26.4.1
CPU: (14) arm64 Apple M4 Pro
Memory: 1.61 GB / 48.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 22.14.0
path: /nix/store/04fc23dsflkxl4s9p6lkigia1hq3vjp2-nodejs-22.14.0/bin/node
Yarn:
version: 1.22.19
path: /Users/sudoplz/.nix-profile/bin/yarn
npm:
version: 10.9.2
path: /nix/store/04fc23dsflkxl4s9p6lkigia1hq3vjp2-nodejs-22.14.0/bin/npm
Watchman:
version: 2024.03.11.00
path: /Users/sudoplz/.nix-profile/bin/watchman
Managers:
CocoaPods:
version: 1.15.2
path: /Users/sudoplz/.nix-profile/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 25.2
- iOS 26.2
- macOS 26.2
- tvOS 26.2
- visionOS 26.2
- watchOS 26.2
IDEs:
Xcode:
version: 26.2/17C52
path: /usr/bin/xcodebuild
Languages:
Java:
version: 21.0.7
Ruby:
version: 3.4.4
path: /Users/sudoplz/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli":
installed: 20.1.0
wanted: 20.1.0
react:
installed: 19.2.3
wanted: 19.2.3
react-native:
installed: 0.85.2
wanted: 0.85.2
iOS:
hermesEnabled: true
newArchEnabled: true
Stacktrace or Logs
None — not a crash. The next render after display flips back simply shows a freshly-constructed host view with default state.
Reproducer
https://github.com/SudoPlz/reproducer-react-native
Screenshots and Videos
https://github.com/user-attachments/assets/bc7f1193-87ec-4c3b-b0d2-45947e32faa9
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
まずリンク先の行にある packages/react-native/ReactCommon/react/renderer/mounting/Differentiator.cpp から始め、次に iOS Fabric で SudoPlz/reproducer-react-native の例を実行します。display:none の経路を追跡し、display を切り替えたときの dealloc と状態の喪失を確認します。意図された iOS の動作が確立され、display の切り替えによって host view の状態が予期せず失われなくなれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- ios, react-native
- 領域
- mobile
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 静か
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 52/100