react / react/react-native

Spaces in folder name breaks iOS build

Ouverte
#54,167 3 commentaires 1 réaction 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Platform: iOS Resolution: PR Submitted
Langage dominant
C++
Étoiles
127k
Forks
25.3k
Merge moyen
1 j 23 h
PR mergées (30 j)
4

Description

Description

Noticed this change while investigating #54140, but having a space in your folder name still results in a broken build (at least with the default XCode build phases).

A fix that seems to work for me is changing the "Bundle React code" build phase to include extra quotes to double wrap the file paths like so:

set -e

WITH_ENVIRONMENT="\"$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh\""
REACT_NATIVE_XCODE="\"$REACT_NATIVE_PATH/scripts/react-native-xcode.sh\""

/bin/sh -c "$WITH_ENVIRONMENT $REACT_NATIVE_XCODE"
Steps to reproduce
  1. Clone the repo, yarn, pod install.
  2. Change the directory name to one with spaces (e.g. mv repo "space bug")
  3. Optionally add set -x to the "Bundle React Native code and images" build phase to view the shell commands executed.
  4. Attempt to build the xcode workspace.
React Native Version

0.82.0

Affected Platforms

Build - MacOS

Output of npx @react-native-community/cli info
System:
  OS: macOS 15.5
  CPU: (10) arm64 Apple M1 Pro
  Memory: 220.09 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 22.17.1
    path: /Users/davidliu/.nvm/versions/node/v22.17.1/bin/node
  Yarn:
    version: 3.6.4
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.9.2
    path: /Users/davidliu/.nvm/versions/node/v22.17.1/bin/npm
  Watchman:
    version: 2025.02.17.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.16.2
    path: /Users/davidliu/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.5
      - iOS 18.5
      - macOS 15.5
      - tvOS 18.5
      - visionOS 2.5
      - watchOS 11.5
  Android SDK:
    API Levels:
      - "24"
      - "27"
      - "28"
      - "29"
      - "30"
      - "31"
      - "32"
      - "33"
      - "34"
      - "35"
      - "36"
    Build Tools:
      - 27.0.3
      - 28.0.3
      - 29.0.0
      - 29.0.2
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 32.0.0
      - 33.0.0
      - 33.0.1
      - 33.0.2
      - 34.0.0
      - 35.0.0
      - 35.0.0
      - 35.0.0
      - 36.0.0
    Android NDK: Not Found
IDEs:
  Android Studio: 2025.1 AI-251.26094.121.2512.13840223
  Xcode:
    version: 16.4/16F6
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.14
    path: /opt/homebrew/opt/sdkman-cli/libexec/candidates/java/current/bin/javac
  Ruby:
    version: 3.3.5
    path: /Users/davidliu/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 20.0.0
    wanted: 20.0.0
  react:
    installed: 19.1.1
    wanted: 19.1.1
  react-native:
    installed: 0.82.0
    wanted: 0.82.0
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: true
Stacktrace or Logs
+ WITH_ENVIRONMENT='/Users/davidliu/github/space bug/ReproducerApp/ios/Pods/../../node_modules/react-native/scripts/xcode/with-environment.sh'
+ REACT_NATIVE_XCODE='/Users/davidliu/github/space bug/ReproducerApp/ios/Pods/../../node_modules/react-native/scripts/react-native-xcode.sh'
+ /bin/sh -c '/Users/davidliu/github/space bug/ReproducerApp/ios/Pods/../../node_modules/react-native/scripts/xcode/with-environment.sh /Users/davidliu/github/space bug/ReproducerApp/ios/Pods/../../node_modules/react-native/scripts/react-native-xcode.sh'
/bin/sh: /Users/davidliu/github/space: No such file or directory
MANDATORY Reproducer

https://github.com/davidliu/react-native-space-bug

Screenshots and Videos

No response

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez par la phase de build Bundle React code and images et par les points d’entrée scripts/xcode/with-environment.sh et scripts/react-native-xcode.sh indiqués dans les logs. Reproduisez le build après avoir déplacé le dépôt vers un chemin contenant des espaces, puis vérifiez que l’espace de travail Xcode se construit correctement depuis ce chemin.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
ios, react-native, shell
Domaine
build-system, mobile
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Calme
Clarté
Clairement spécifiée
Accessibilité débutants
55/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.