[Android] Timing of NativeCommands delivery vs. calls of TurboModule methods vs. AppState changes
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- C++
- Estrellas
- 127k
- Forks
- 25.3k
- Merge medio
- 1 d 23 h
- PR fusionados (30 d)
- 4
Descripción
Description
Not sure, is it a bug, or a peculiarity of the new architecture, but here is my scenario. My app uses RN 0.74.2, with new arch, bridgeless. It has an internal web server (my @dr.pogodin/react-native-static-server — a TurboModule), and it has a WebView (my slightly enhanced fork of react-native-webview — a Fabric component), which loads assets from that web server. When the app goes into background I want to abort any in-flight loading by RN WebView, and then shutdown the server. To do so, I listen for AppState change, and when the state changes to background I call RN WebView's stopLoading() method, and my server's stop() command; both calls are passed to the native side, via Fabric's NativeCommand in WebView case, and via TurboModule method call in my server's case.
Now I am testing it on Android, with a bunch of debug logging, and native debugger at hands. I see the following:
- I send my app to the background.
- Both WebView's
stopLoading()and server'sstop()are called in JS layer. - The server's TurboModule
stop()operation is successfully executed in the native layer, and it even manages to emit back a notification that server stopped (usingRCTDeviceEventEmitter) so that in JS layer a message is printed to the console that server successfully stopped. - However; the WebViews
stopLoading()command is not triggered at the native side — not until the app is brought back to the foreground again, immediately after which I capture by the debugger that it has been triggered.
My expectation here, especially considering that TurboModule has no problem to trigger native call, and deliver backward event to JS immediately after the app state changed to background, that the same should work for Fabric components; however, it is not the case. What do you think? Is it a bug? Or a limitation of the current new arch implementation for components? Or is it RN WebView's code uses a stale approach to operate native commands (though, it seems it follows what is currently documented here)?
Steps to reproduce
N/A
React Native Version
0.74.2
Affected Platforms
Runtime - Android
Areas
Other (please specify)
Output of npx react-native info
N/A
Stacktrace or Logs
N/A
Reproducer
https://github.com/birdofpreyru/issue-45017
Screenshots and Videos
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con el reproducer enlazado en https://github.com/birdofpreyru/issue-45017 y sigue las rutas de entrega de Android para Fabric NativeCommands, las llamadas a TurboModule y los cambios de AppState. Compara la llamada stopLoading() de WebView con la llamada stop() del servidor; se considera terminado cuando se explica el comportamiento de orden o bloqueo y se establece claramente el comportamiento esperado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- android, javascript, react-native
- Área
- mobile-dev
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 28/100