[android] PlatformColor does not respond to dark | light mode changes on android ?
Nessuno ha ancora preso questa issue.
- Lingua principale
- C++
- Stelle
- 127k
- Fork
- 25.3k
- Merge medio
- 1g 23h
- PR unite (30g)
- 4
Descrizione
Description
PlatformColor on android does not pickup the correct color on theme changes as it does on IOS.
it's worth mentioning that useColorScheme does pick up the device theme correctly.
Version
66.4
Output of npx react-native info
System:
OS: macOS 11.6.1
CPU: (8) x64 Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Memory: 295.98 MB / 32.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.13.1 - /usr/local/bin/node
Yarn: 1.22.15 - ~/.yarn/bin/yarn
npm: 8.1.2 - ~/n/bin/npm
Watchman: 2021.12.20.00 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.0.1, iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0
Android SDK:
API Levels: 28, 29, 30, 31
Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.2, 31.0.0
System Images: android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: Arctic Fox 2020.3.1 Patch 3 Arctic Fox 2020.3.1 Patch 3
Xcode: 13.1/13A1030d - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_292 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.66.4 => 0.66.4
react-native-macos: Not Found
npmGlobalPackages:
*react-native*: Not Found
Steps to reproduce
after creating a react native project.
[1] create a values-night/colors.xml and values/colors.xml inside android/app/src/main/res
[2] add both dark mode and light mode colors to both colors.xml files accordingly.
<?xml version="1.0" encoding="utf-8"?>
<resources>
<color name="text">#000000</color>
<color name="background">#FFFFFF</color>
</resources>
<?xml version="1.0" encoding="utf-8"?>
<resources>
<color name="text">#FFFFFF</color>
<color name="background">#000000</color>
</resources>
[3] rebuild the app.
[4] change your device theme from settings
observation:
colors don't react to the device theme.
[5] try changing your device theme then reloading from dev menu.
observation:
colors change & respect the device theme after reload.
[6] removing uiMode from android:configChanges inside inside AndroidManifest.xml does resolve the issue however it's performant ( the application would then be torn down and recreated with the theme change ).
Snack, code example, screenshot, or link to a repository
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia riproducendo il comportamento con l’esempio collegato platformColorAndroidIssue, usando le risorse values/colors.xml e values-night/colors.xml descritte nell’issue. Confronta PlatformColor con useColorScheme mentre cambi il tema del dispositivo e ispeziona AndroidManifest.xml, in particolare android:configChanges e uiMode. Il lavoro è completo quando PlatformColor si aggiorna al cambio del tema senza richiedere un reload o lo smontaggio dell’applicazione.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- android, react-native
- Ambito
- mobile
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 45/100