react-navigation / react-navigation/react-navigation.github.io
The documentation on type scripting nested navigation is unclear
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- JavaScript
- Estrellas
- 324
- Forks
- 2k
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
Current Behavior
- What code are you running and what is happening?
- Include a screenshot or video if it makes sense.
I'm trying to setup typescript for navigating into a nested navigator. From reading the doc, this was my attempt (which I'm assuming is wrong. It gives me''Create Conversation modal'' is referenced directly or indirectly in its own type annotation.ts(2502.
export type RootStackParamList = {
Home: undefined;
SignInUpTunnel: undefined;
'Create Conversation modal': NavigatorScreenParams<EditConversationModalNavigatorParamList>; <==== typescript error here
};
...
return
<AuthenticatedUserProvider>
<Stack.Navigator screenOptions={{ headerShown: false }} mode="modal">
<Stack.Screen name="Home" component={HomeDrawerNavigator} />
<Stack.Screen name="Create Conversation modal" component={EditConversationModalNavigator} />
</Stack.Navigator>
</AuthenticatedUserProvider>
...
export type EditConversationModalNavigatorParamList = RootStackParamList & {
'Create conversation': { userToInvite: UserConversationStatusCellData | null };
};
...
navigation.navigate('Create Conversation modal', { screen: 'Create conversation', params: { userToInvite } });
Unfortunately, the documentation on this topic is very thin: https://reactnavigation.org/docs/typescript#type-checking-screens-and-params-in-nested-navigator.
Also, the documentation uses a different navigation structure than the documentation for nesting navigators. making it hard to know where to actually put the NavigatorScreenParams and what paramList to give it.
Expected Behavior
I would expect the documentation for the typescripting of a nested navigator to include a full example (with the root navigator and nested navigator) and I would expect it to use the same navigators as the documentation to nest navigator.
How to reproduce
- You must provide a way to reproduce the problem. If you are having an issue with your machine or build tools, the issue belongs on another repository as that is outside of the scope of React Navigation.
- Either re-create the bug on Snack or link to a GitHub repository with code that reproduces the bug.
- Explain how to run the example app and any steps that we need to take to reproduce the issue from the example app.
- Keep the repro code as simple as possible, with the minimum amount of code required to repro the issue.
- Before reporting an issue, make sure you are on the latest version of the package.
Your Environment
| software | version |
|---|---|
| typescript 4.0.7 | |
| @react-navigation/native 5.9.3 | |
| react-native | |
| expo 40 | |
| node 14.6.0 | |
| npm or yarn 1.22.10 |
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza por la página de TypeScript sobre navegación anidada y la documentación separada sobre anidamiento de navigators enlazada en el issue. Compara sus estructuras de navigator y usa RootStackParamList y EditConversationModalNavigatorParamList indicados como contexto de ejemplo. Se considera terminado cuando la página de TypeScript incluye un ejemplo completo y coincidente de un navigator raíz y un navigator anidado que explica dónde corresponde NavigatorScreenParams.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- react-native, typescript
- Área
- documentation
- Tipo de issue
- Documentación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 35/100