error: use of undeclared identifier 'MAP_ANONYMOUS'
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- cpp, macos
- Domain
- build-system, operating-systems
Research direction
Start with absl/debugging/internal/examine_stack.cc and absl/debugging/internal/stack_consumption.cc, then compare the existing portability handling in low_level_alloc.cc, failure_signal_handler.cc, and s2/base/port.h. Confirm the compatibility change covers OS X 10.10 and earlier, while preserving behavior on newer Darwin systems, and verify that s2 builds successfully.
Written by the indexing model from the issue text.
Description
s2 fails to build on OS X 10.10 and earlier:
https://trac.macports.org/ticket/67784
absl/debugging/internal/examine_stack.cc:58:34: error: use of undeclared identifier 'MAP_ANONYMOUS'
MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
^
1 error generated.
MAP_ANONYMOUS is equivalent to MAP_ANON which is available on older systems.
There are several places where you already have code to address this:
Note that the comment is outdated: MAP_ANONYMOUS does exist on Darwin in OS X 10.11 (released 2015) and later.
There are two places where similar code needs to be added, or it needs to be moved into a more central include file:
I see no reason to limit the fix to systems where __APPLE__ is defined.
- Dominant language
- C++
- Stars
- 81
- Forks
- 19
- Avg merge
- 20h 25m
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from r-spatial/s2
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gazebosim/gz-sensors#662 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LadybirdBrowser/ladybird#12123 ·