`cmake` detection appears to be broken for Linux builds
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 81
- Forks
- 19
- Avg merge
- 20h 25m
- Merged PRs (30d)
- 3
Description
According to https://github.com/r-spatial/s2/blob/ff3f7273fe3e52fd12fcc4a9a4c44ec4452af843/tools/build_absl.sh#L22-L23 we are checking if CMAKE env variable is empty and then first set CMAKE to which cmake (appropriate for Linux envs) but in the next line we overwrite the same with the MacOS equivalent without checking if we are on MacOS or not.
It would be great to make those two checks work on both Linux and MacOS so that s2 can use Linux's cmake to build Abseil as a system dependency.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read tools/build_absl.sh around lines 22-23 to trace how the CMAKE environment variable is selected for Linux and macOS. Verify the resulting behavior by checking builds on both platforms; done means Linux can use its system cmake to build Abseil without breaking macOS detection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, shell
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100