feat: `testthat::snapshot_download_gh()` should prompt user to run accept/review code

Open
#2,322 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
testing

Research direction

Start at the testthat::snapshot_download_gh() entry point and compare where its existing GitHub Actions log prompt is produced. Make the completed download flow display the requested snapshot_accept() and snapshot_review() instructions, then verify that the prompt appears after downloads finish.

Written by the indexing model from the issue text.

Description

I believe there is a lot of context switching when trying to get snapshots downloaded and accepting them.

With IDEs being better about clicking code to run, after all downloads are completed, I'm wanting to be prompted with:

── Snapshots ─────
To review and process snapshots locally:
* Run `testthat::snapshot_accept()` to accept all changes.
* Run `testthat::snapshot_review()` to review all changes.

Currently, this prompt is only within the GHA logs, not where the code is being run.

Dominant language
R
Stars
939
Forks
346
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from r-lib/testthat

All issues in r-lib/testthat

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.