inverted `skip_if` logic in 'skipping' vingette?
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- r
- Domain
- documentation
Research direction
Update the vignettes/skipping.Rmd example at lines 65-66, starting by checking the current skip_if condition against the vignette's opt-in wording. Ensure the example skips slow tests unless RUN_SLOW_TESTS is set to true, while preserving the intended contrast with skip_if_not.
Written by the indexing model from the issue text.
Description
The skipping vignette shows
Unless I'm mistaken, this would cause the tests to be skipped if we say we want to run them.
To keep the opt-in phrasing (and show an example of skip_if versus skip_if_not, which is what the previous two show), something like
skip_if(Sys.getenv("RUN_SLOW_TESTS") != "true")
might do?
- Dominant language
- R
- Stars
- 939
- Forks
- 346
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from r-lib/testthat
-
Documentation for expect_error argument 'regexp' says it accepts a character vector but it does not Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 3/5 1-2 days Newbie friendliness 66/100
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·