Invalid overloads in `asyncio.(base_)events`
オープン
@JelleZijlstra がすでに取り組んでいます。
2023年2月1日 から。
topic: asyncio
- 主要言語
- Python
- スター
- 5.1k
- フォーク
- 2.1k
- 平均マージ
- 1日 19時間
- マージ済み PR(30日)
- 82
説明
Stubdefaulter would like us to apply this diff to our asyncio stubs. Stubdefaulter is correct about what the defaults are for these functions at runtime, but mypy correctly points out that applying this diff as-is would be invalid: a parameter annotated with str cannot have a None default, etc. etc.
Plainly, these overloads are incorrect in some way. Unfortunately, I'm not sure what the correct fix is. I'd appreciate it if somebody who knows their asyncio better than I do would be able to take a look :)
(This is a followup issue to #9608, which is completed other than this remaining issue.)
The affected functions are:
asyncio.base_events.create_connectionasyncio.base_events.create_serverasyncio.events.create_connectionasyncio.events.create_server
diff --git a/stdlib/asyncio/base_events.pyi b/stdlib/asyncio/base_events.pyi
index 3b8f28671..7e0601863 100644
--- a/stdlib/asyncio/base_events.pyi
+++ b/stdlib/asyncio/base_events.pyi
@@ -156,8 +156,8 @@ class BaseEventLoop(AbstractEventLoop):
async def create_connection(
self,
protocol_factory: Callable[[], _ProtocolT],
- host: str = ...,
- port: int = ...,
+ host: str = None,
+ port: int = None,
*,
ssl: _SSLContext = None,
family: int = 0,
@@ -284,7 +284,7 @@ class BaseEventLoop(AbstractEventLoop):
self,
protocol_factory: _ProtocolFactory,
host: str | Sequence[str] | None = None,
- port: int = ...,
+ port: int = None,
*,
family: int = ...,
flags: int = ...,
@@ -305,7 +305,7 @@ class BaseEventLoop(AbstractEventLoop):
*,
family: int = ...,
flags: int = ...,
- sock: socket = ...,
+ sock: socket = None,
backlog: int = 100,
ssl: _SSLContext = None,
reuse_address: bool | None = None,
diff --git a/stdlib/asyncio/events.pyi b/stdlib/asyncio/events.pyi
index b2292801e..cff0775d6 100644
--- a/stdlib/asyncio/events.pyi
+++ b/stdlib/asyncio/events.pyi
@@ -250,8 +250,8 @@ class AbstractEventLoop:
async def create_connection(
self,
protocol_factory: Callable[[], _ProtocolT],
- host: str = ...,
- port: int = ...,
+ host: str = None,
+ port: int = None,
*,
ssl: _SSLContext = None,
family: int = 0,
@@ -388,7 +388,7 @@ class AbstractEventLoop:
self,
protocol_factory: _ProtocolFactory,
host: str | Sequence[str] | None = None,
- port: int = ...,
+ port: int = None,
*,
family: int = ...,
flags: int = ...,
@@ -410,7 +410,7 @@ class AbstractEventLoop:
*,
family: int = ...,
flags: int = ...,
- sock: socket = ...,
+ sock: socket = None,
backlog: int = 100,
ssl: _SSLContext = None,
reuse_address: bool | None = None,
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
評価
この issue はまだ評価されていません。