Duplicate keys cause earlier TypedDict values to be skipped during type checking
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Python
- Sterne
- 20.6k
- Forks
- 3.3k
- PR-Merge-Kennzahlen
- PR-Kennzahlen ausstehend
Beschreibung
Bug Report
When a dictionary literal used to construct a TypedDict contains duplicate
keys, mypy only type-checks the final value for that key. Earlier value
expressions are skipped entirely.
This can hide real errors because Python still evaluates every value expression
in the dictionary literal, including values that are later overwritten by a
duplicate key.
To Reproduce
from typing import TypedDict
class Payload(TypedDict):
value: int
def parse(value: str) -> int:
return len(value)
payload = Payload({"value": parse(123), "value": 0})
$ mypy --show-error-codes --no-incremental example.py
Success: no issues found in 1 source file
Running the program demonstrates that the skipped expression is evaluated:
TypeError: object of type 'int' has no len()
Expected Behavior
Mypy should type-check every value expression in the dictionary literal, even
if a later duplicate key determines the final value of the TypedDict field.
In this example, it should report an error similar to:
error: Argument 1 to "parse" has incompatible type "int"; expected "str" [arg-type]
The same expression is correctly rejected when the target is a regular
dict[str, int]. The issue also occurs with a contextually typed literal:
payload: Payload = {"value": parse(123), "value": 0}
Actual Behavior
Mypy reports no issues because only the last value associated with the
duplicate key is checked.
Additional Context
The current implementation replaces the previously collected expression
without type-checking it and has a TODO to type-check all duplicate-key values:
PR #15425 also mentioned repeated TypedDict keys as a known limitation, but I
could not find an existing issue that tracks it:
https://github.com/python/mypy/pull/15425
Environment Used to Reproduce
- Mypy versions used:
mypy 2.3.0 (compiled: yes)mypy 2.4.0+dev.6eb141f03a8b43c274f15cc4978d617a71d8f37e (compiled: no)
- Mypy command-line flags:
--show-error-codes --no-incremental - Mypy configuration options: none
- Python version used: 3.12.8
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne in mypy/checkexpr.py bei den Zeilen 839–842 und reproduziere das Problem mit example.py unter Verwendung des bereitgestellten mypy-Befehls. Verfolge, wie doppelte TypedDict-Schlüssel frühere Ausdrücke ersetzen; abgeschlossen ist die Aufgabe, wenn jeder Wertausdruck typgeprüft wird und der Fall parse(123) den erwarteten arg-type-Fehler meldet.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- compilers
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 74/100