Variable assigned in branches of an if statement is considered as being redefined
まだ誰も着手していません。
- 主要言語
- Python
- スター
- 20.6k
- フォーク
- 3.3k
- PR マージ指標
- PR 指標を取得中
説明
Bug Report
The same variable assigned in different branches of an if statement is considered as being redefined, despite the fact that at in reality there is only one assignment being performed, it's just unknown at that stage which branch will be taken.
To Reproduce
from io import BytesIO
from typing import ClassVar
class IntegerAdapter:
_size_: ClassVar[int] = 4
@classmethod
def from_wire(cls, buffer: bytes | bytearray | memoryview | BytesIO) -> int:
if isinstance(buffer, BytesIO):
data = buffer.read(cls._size_)
else:
data = buffer[:cls._size_]
return int.from_bytes(data, byteorder='big', signed=True)
Expected Behavior
I would expect mypy to infer the type of the variable as the union of the types in all branches. This is not really a redefinition since the variable is not assigned twice in succession, only one branch is taken, it's just unknown which one.
Using --allow-redefinition doesn't help as one of the requirements for that is to read the variable before the next assignment, which is impossible.
Also the behavior is inconsistent with different ways of writing the if statement. Inverting the condition and reversing the branches makes the error go away. So does using an equivalent conditional expression.
Any of the following ways to rewrite the if statement will eliminate the error, but one should not have to retort to such gimmicks to avoid this.
# this works because the 1st assignment is the one with a wider type that includes the type of the 2nd
if not isinstance(buffer, BytesIO):
data = buffer[:cls._size_]
else:
data = buffer.read(cls._size)
# this works because the type is correctly inferred to be the union of the branch types
data = buffer.read(cls._size_) if isinstance(buffer, BytesIO) else buffer[:cls._size_]
IMO the conditional statement is the only one that behaves correctly here as it infers the type as the union of the two.
But semantically the if-else and the conditional statement are the same, just differently written: take one branch and assign computed value to the variable.
Actual Behavior
typing-6.py:14: error: Incompatible types in assignment (expression has type "bytes | bytearray | memoryview", variable has type "bytes") [assignment]
Found 1 error in 1 file (checked 1 source file)
Your Environment
- Mypy version used: mypy 1.12.0+dev.6a0657e5959ba1777c4d427f8f355d499035d145 (compiled: no)
- Mypy command-line flags: with or without --allow-redefinition, makes no difference
- Mypy configuration options from
mypy.ini(and other config files):
[tool.mypy]
enable_incomplete_feature = "NewGenericSyntax"
disable_bytearray_promotion = true
disable_memoryview_promotion = true
check_untyped_defs = true
warn_unreachable = true
warn_redundant_casts = true
warn_unused_ignores = true
- Python version used: 3.12
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
提供された Python reproducer を mypy と示された設定で実行することから始め、if-else 形式と同等の条件式を比較します。分岐での代入がどのようにチェックされるかを追跡し、if-else のケースで互換性のない再定義を報告せずに union を推論するようにします。reproducer がエラーなしで完了することを確認します。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python
- 領域
- tooling
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100