python / python/cpython

Remove distracted red bar from IDLE for some SyntaxErrors

Aperta
#93,966 3 commenti 0 reazioni 1 assegnatario Vedi su GitHub

@terryjreedy ci sta già lavorando.

Dal 17/6/2022.

topic-IDLE type-bug
Lingua principale
Python
Stelle
77.2k
Fork
36k
Metriche di merge delle PR
Metriche PR in attesa

Descrizione

Bug report

This may be more an distracting cosmetic issue than a true bug, but it is something that can be fixed easily.

As Raymond Hettinger mentioned a while ago on Twitter (https://twitter.com/raymondh/status/1501700903870468099), when a SyntaxError is raised and the location corresponds to the "\n" at the end of a line, a huge red highlighted region is shown at the end of the invalid line.

For example, type

from math

followed by enter. This red highlighted line will remain on the screen until another SyntaxError occurs.
Unlike cases where a SyntaxError highlights just a few characters pointing at a specific problem, this adds really no informative value, once the user starts entering some new code.

Your environment

I have reproduced this will IDLE on Windows 10 on all Python versions I have installed, from 3.6 to 3.11 inclusively.

Proposed fix

I have been able to fix this on a custom version of IDLE (friendly_idle) by doing the following:

In pyshell.ModifiedInterpreter.transfer_path which sets up some values at the beginning of a new process,
define the following:

self.error_at_end_of_line = False

In pyshell.ModifiedInterpreter.showsyntaxerror, add the last line shown below:

        if lineno == 1:
            pos = "iomark + %d chars" % (offset - 1)
        else:
            pos = "iomark linestart + %d lines + %d chars" % (lineno - 1, offset - 1)
        self.error_at_end_of_line = text.get(pos) == "\n"  # <-- add this

At the beginning of pyshell.ModifiedInterpreter.runsource, add the following:

        if self.error_at_end_of_line:
            self.error_at_end_of_line = False
            self.tkconsole.text.tag_remove("ERROR", "1.0", "end")

If desired, I could do a pull request that would include these changes.

Linked PRs
  • gh-157595

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.