Remove distracted red bar from IDLE for some SyntaxErrors

Ouverte
#93,966 3 commentaires 0 réactions 1 personne assignée Voir sur GitHub

@terryjreedy y travaille déjà.

Depuis le 17/6/2022.

Évaluation

Cette issue n'a pas encore été évaluée.

Description

topic-IDLE type-bug

Bug report

This may be more an distracting cosmetic issue than a true bug, but it is something that can be fixed easily.

As Raymond Hettinger mentioned a while ago on Twitter (https://twitter.com/raymondh/status/1501700903870468099), when a SyntaxError is raised and the location corresponds to the "\n" at the end of a line, a huge red highlighted region is shown at the end of the invalid line.

For example, type

from math

followed by enter. This red highlighted line will remain on the screen until another SyntaxError occurs.
Unlike cases where a SyntaxError highlights just a few characters pointing at a specific problem, this adds really no informative value, once the user starts entering some new code.

Your environment

I have reproduced this will IDLE on Windows 10 on all Python versions I have installed, from 3.6 to 3.11 inclusively.

Proposed fix

I have been able to fix this on a custom version of IDLE (friendly_idle) by doing the following:

In pyshell.ModifiedInterpreter.transfer_path which sets up some values at the beginning of a new process,
define the following:

self.error_at_end_of_line = False

In pyshell.ModifiedInterpreter.showsyntaxerror, add the last line shown below:

        if lineno == 1:
            pos = "iomark + %d chars" % (offset - 1)
        else:
            pos = "iomark linestart + %d lines + %d chars" % (lineno - 1, offset - 1)
        self.error_at_end_of_line = text.get(pos) == "\n"  # <-- add this

At the beginning of pyshell.ModifiedInterpreter.runsource, add the following:

        if self.error_at_end_of_line:
            self.error_at_end_of_line = False
            self.tkconsole.text.tag_remove("ERROR", "1.0", "end")

If desired, I could do a pull request that would include these changes.

Linked PRs
  • gh-157595
Langage dominant
Python
Étoiles
77.2k
Forks
36k
Merge moyen
1 j 9 h
PR mergées (30 j)
558

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de python/cpython

Toutes les issues de python/cpython

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.