Remove distracted red bar from IDLE for some SyntaxErrors

Offen
#93,966 3 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@terryjreedy arbeitet bereits daran.

Seit 17.6.2022.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

topic-IDLE type-bug

Bug report

This may be more an distracting cosmetic issue than a true bug, but it is something that can be fixed easily.

As Raymond Hettinger mentioned a while ago on Twitter (https://twitter.com/raymondh/status/1501700903870468099), when a SyntaxError is raised and the location corresponds to the "\n" at the end of a line, a huge red highlighted region is shown at the end of the invalid line.

For example, type

from math

followed by enter. This red highlighted line will remain on the screen until another SyntaxError occurs.
Unlike cases where a SyntaxError highlights just a few characters pointing at a specific problem, this adds really no informative value, once the user starts entering some new code.

Your environment

I have reproduced this will IDLE on Windows 10 on all Python versions I have installed, from 3.6 to 3.11 inclusively.

Proposed fix

I have been able to fix this on a custom version of IDLE (friendly_idle) by doing the following:

In pyshell.ModifiedInterpreter.transfer_path which sets up some values at the beginning of a new process,
define the following:

self.error_at_end_of_line = False

In pyshell.ModifiedInterpreter.showsyntaxerror, add the last line shown below:

        if lineno == 1:
            pos = "iomark + %d chars" % (offset - 1)
        else:
            pos = "iomark linestart + %d lines + %d chars" % (lineno - 1, offset - 1)
        self.error_at_end_of_line = text.get(pos) == "\n"  # <-- add this

At the beginning of pyshell.ModifiedInterpreter.runsource, add the following:

        if self.error_at_end_of_line:
            self.error_at_end_of_line = False
            self.tkconsole.text.tag_remove("ERROR", "1.0", "end")

If desired, I could do a pull request that would include these changes.

Linked PRs
  • gh-157595
Vorherrschende Sprache
Python
Sterne
77.2k
Forks
36k
Ø Merge
1 T. 9 Std.
Gemergte PRs (30 T.)
558

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus python/cpython

Alle Issues in python/cpython

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.