Lib/types.py nit: isinstance != PyType_IsSubtype

Open
#67,157 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by reading Lib/types.py and the linked fix_types_calculate_meta patch files, then inspect the referenced virtual-metaclass test patches. Compare the Python implementation with the native type machinery; done means the behavior matches PyType_IsSubtype and the corresponding tests pass.

Written by the indexing model from the issue text.

Description

stdlib type-bug
BPO 22968
Nosy @1st1
Files
  • fix_types_calculate_meta.patch: More correct implementation of types._caclculate_meta
  • fix_types_calculate_meta_v2.patch: v2: More correct implementation of class creation APIs in Lib/types.py
  • fix_types_calculate_meta_v3.patch: v3: Just adds a commit message
  • test_virtual_metaclasses.patch: Tests verifying that type machinery really works this way
  • test_virtual_metaclasses_in_types_module.patch: Tests verifying that types.py matches type machinery
  • test_virtual_metaclasses_in_types_module_v2.patch: Tests verifying that types.py implementation matches native type machinery
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2014-11-29.20:38:33.991>
labels = ['type-bug', 'library']
title = 'Lib/types.py nit: isinstance != PyType_IsSubtype'
updated_at = <Date 2015-10-24.15:02:13.263>
user = 'https://bugs.python.org/gmt'

    bugs.python.org fields:

    activity = <Date 2015-10-24.15:02:13.263>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2014-11-29.20:38:33.991>
creator = 'gmt'
dependencies = []
files = ['37318', '37348', '37349', '37350', '37352', '37356']
hgrepos = []
issue_num = 22968
keywords = ['patch']
message_count = 7.0
messages = ['231871', '231980', '232067', '232074', '232075', '232077', '232104']
nosy_count = 2.0
nosy_names = ['yselivanov', 'gmt']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22968'
versions = ['Python 3.4', 'Python 3.5', 'Python 3.6']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.