Add `signal.get_wakeup_fd()`
まだ誰も着手していません。
- 主要言語
- Python
- スター
- 77.2k
- フォーク
- 35.9k
- PR マージ指標
- PR 指標を取得中
説明
Feature or enhancement
Proposal:
We have signal.set_wakeup_fd(), which sets a new file descriptor and returns the old one. However, there are at least three cases where we want to get the current wakeup fd without setting a new one:
- Obtaining debug information about the current state of the process, which also applies to tests (how can we ensure that a particular function actually sets the wakeup fd?).
- Raising warnings if it has been changed (reset to -1?) in some scope we are considering.
- Conditionally setting the wakeup fd depending on whether it has been changed in another scope.
The reason I opened this issue relates to the third case. I have an "inner" wakeup fd (guest) and an "outer" wakeup fd (host). When the outer wakeup fd is either not set (equal to -1) or equal to the inner wakeup fd, it is updated along with the inner one. In this case:
- If I do not set/get wakeup fd, I will not know the current inner wakeup fd, and as a result, I will not be able to perform checks.
- If I always set the outer wakeup fd when exiting the inner scope, then in case of equality, this may happen when the wakeup fd has already been closed (and reset to -1) in the inner scope, which in turn will lead to either an
OSErroror a possible write to a false file descriptor (since file descriptors are reusable). - I also cannot set the inner wakeup fd, since it could have been updated in the inner scope.
- The code in the inner scope is not under my control.
The simplest implementation of signal.get_wakeup_fd() at the Python level looks like this:
import signal
def get_wakeup_fd():
fd = signal.set_wakeup_fd(-1)
signal.set_wakeup_fd(fd)
return fd
However, it has two drawbacks:
- We lose the current value of the
warn_on_full_bufferparameter. - There is a race condition between the two
signal.set_wakeup_fd()calls (what if a signal is sent to the process during this time?), which can lead to lost signals (and thus the guest not waking up).
To solve the race condition problem, we would have to create our own wakeup pair, for example in the form of a non-blocking pipe, and send signals from the pipe to the current wakeup fd, effectively emulating the trip_signal() function. But this only sounds simple on Unix. On Windows:
-
It is not possible to create a non-blocking pipe using the public API without
ctypesuntil Python 3.12. The closest alternative using the private API would look like this:from _winapi import SetNamedPipeHandleState from msvcrt import get_osfhandle def set_blocking(pipefd, blocking, /): SetNamedPipeHandleState( get_osfhandle(pipefd), 0 if blocking else 1, None, None, ) -
We cannot use
os.write()if the wakeup fd is a socket. In this case, we would either have to try to handle sockets viasocket.fromfd(), or use an alternative approach withsignal.signal()+signal.raise_signal()(disable the current signal handlers, implicitly calltrip_signal()by resending signals to the current process, enable them back), but the latter is even more non-trivial and is unlikely to have a correct solution.
Meanwhile, at the signalmodule.c level, to get the current wakeup fd, it is enough to just get wakeup.fd. So why not add the corresponding function?
import signal
fd = signal.get_wakeup_fd()
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
- gh-145726
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
Modules/signalmodule.c から始め、特に wakeup.fd の状態と issue にリンクされている trip_signal() のパスを確認してください。既存の signal.set_wakeup_fd() の動作とそのドキュメントを確認してから、着手する前にリンクされている PR gh-145726 を調査してください。ここで説明されている race または warn_on_full_buffer の制限なしに現在の wakeup fd を取得でき、関連するプラットフォーム全体で動作がカバーされていれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- c, python
- 領域
- operating-systems
- issue の種類
- 機能追加
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100