wsgiref.validate is too restrictive regarding HTTP_CONTENT_LENGTH/TYPE
まだ誰も着手していません。
- 主要言語
- Python
- スター
- 77.2k
- フォーク
- 35.9k
- PR マージ指標
- PR 指標を取得中
説明
Bug report
Bug description:
PEP 3333 specifies that certain CGI environment variables must be placed in the environ dictionary.
The
environdictionary is required to contain these CGI environment variables, as defined by the Common Gateway Interface specification
The CONTENT_TYPE and CONTENT_LENGTH environ variables must be set as follows:
CONTENT_TYPE
The contents of any Content-Type fields in the HTTP request. May be empty or absent.
CONTENT_LENGTH
The contents of any Content-Length fields in the HTTP request. May be empty or absent.
Additionally, HTTP headers must be converted to variables as follows:
HTTP_Variables
Variables corresponding to the client-supplied HTTP request headers (i.e., variables whose names begin with"HTTP_"). The presence or absence of these variables should correspond with the presence or absence of the appropriate HTTP header in the request.
So if the client sends an HTTP Content-Length header, it must be converted into a CONTENT_LENGTH variable, and may be converted into a HTTP_CONTENT_LENGTH variable. However, the CGI specification makes the following additional comment about Content-Length and Content-Type:
The server is not required to create meta-variables for all the header fields that it receives. In particular, it SHOULD remove any header fields carrying authentication information, such as 'Authorization'; or that are available to the script in other variables, such as 'Content-Length' and 'Content-Type'. The server MAY remove header fields that relate solely to client-side communication issues, such as 'Connection'.
In particular note that HTTP_CONTENT_LENGTH should be removed, not must.
On the other hand, wsgiref.validate.validator checks
- That HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH are not in the environment (these headers should appear as CONTENT_LENGTH and CONTENT_TYPE).
I believe this is too restrictive because WSGI servers are not required to remove these headers. In particular, nginx (link to the FastCGI documentation, but similar behavior is present for SCGI and UWSGI) passes all HTTP headers by default except Status and X-Accel-.... Instead, the validator should check that if HTTP_CONTENT_TYPE is present that CONTENT_TYPE is also present (and similarly for CONTENT_TYPE).
CPython versions tested on:
CPython main branch
Operating systems tested on:
No response
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
wsgiref.validate.validator から始め、environ 辞書内の HTTP_CONTENT_TYPE と HTTP_CONTENT_LENGTH の扱いを確認してください。これらの変数について、既存の validator テストがあれば確認してください。対応する CONTENT_ 変数が存在する場合はどちらの HTTP_ 変数も validator が受け入れ、対応する CONTENT_ 変数なしの HTTP_ 変数は引き続き拒否するようになれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python
- 領域
- backend-api-design
- issue の種類
- バグ
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 42/100