Improve usage of `_setSSLError` in `_ssl.c`
未關閉
@picnixz 已經在處理了。
開始於 2025年9月8日。
extension-modules
sprint
topic-SSL
type-refactor
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Proposal:
Based on https://github.com/python/cpython/pull/137198#discussion_r2282082902, we should refactor _setSSLError as the errcode argument is redundant. In addition, we should:
- Change
_ssl__SSLContext_set_ciphers_implto use_setSSLErroras in_ssl__SSLContext_set_ciphersuites_impl. - If possible, ease the use of
_setSSLError. - If possible, ease how we indicate that a functionality is not implemented and document which exception is being actually raised (this needs to be synchronized with https://github.com/python/cpython/issues/138633).
Has this already been discussed elsewhere?
I have already discussed this feature proposal.
Links to previous discussion of this feature:
- https://github.com/python/cpython/pull/138269#discussion_r2328597995
- https://github.com/python/cpython/pull/138269#discussion_r2328703198
- https://github.com/python/cpython/pull/137198#discussion_r22820829
[!NOTE]
I will take care of this myself.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
評估
這個 Issue 還沒有評估資料。