python / python/cpython

Improve usage of `_setSSLError` in `_ssl.c`

未关闭
#138,634 0 条评论 1 个 reaction 已指派 1 人 在 GitHub 查看

@picnixz 已经在做这个了。

开始于 2025年9月8日。

extension-modules sprint topic-SSL type-refactor
主要语言
Python
星标
77.2k
派生
35.9k
PR 合并指标
PR 指标待抓取

描述

Proposal:

Based on https://github.com/python/cpython/pull/137198#discussion_r2282082902, we should refactor _setSSLError as the errcode argument is redundant. In addition, we should:

  • Change _ssl__SSLContext_set_ciphers_impl to use _setSSLError as in _ssl__SSLContext_set_ciphersuites_impl.
  • If possible, ease the use of _setSSLError.
  • If possible, ease how we indicate that a functionality is not implemented and document which exception is being actually raised (this needs to be synchronized with https://github.com/python/cpython/issues/138633).
Has this already been discussed elsewhere?

I have already discussed this feature proposal.

Links to previous discussion of this feature:

[!NOTE]
I will take care of this myself.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。