Fix proxy usage in `test_urllib2_localnet` on macOS
Đang mở
Chưa có ai nhận issue này.
OS-mac
tests
type-bug
- Ngôn ngữ chính
- Python
- Star
- 77.2k
- Fork
- 35.9k
- Chỉ số merge pull request
- Chỉ số pull request đang chờ
Mô tả
Bug description:
On macos run:
make test
Error:
...
ERROR: test_proxy_with_bad_password_raises_httperror (test.test_urllib2_localnet.ProxyAuthTests.test_proxy_with_bad_password_raises_httperror)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 1321, in do_open
h.request(req.get_method(), req.selector, req.data, headers,
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
encode_chunked=req.has_header('Transfer-encoding'))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1342, in request
self._send_request(method, url, body, headers, encode_chunked)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1388, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1337, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1097, in _send_output
self.send(msg)
~~~~~~~~~^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1041, in send
self.connect()
~~~~~~~~~~~~^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1007, in connect
self.sock = self._create_connection(
~~~~~~~~~~~~~~~~~~~~~~~^
(self.host,self.port), self.timeout, self.source_address)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/socket.py", line 879, in create_connection
raise exceptions[0]
File "/Users/hyi/prs/cpython/Lib/socket.py", line 864, in create_connection
sock.connect(sa)
~~~~~~~~~~~~^^^^
ConnectionRefusedError: [Errno 61] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/hyi/prs/cpython/Lib/test/test_urllib2_localnet.py", line 368, in test_proxy_with_bad_password_raises_httperror
self.opener.open(self.URL)
~~~~~~~~~~~~~~~~^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 487, in open
response = self._open(req, data)
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 504, in _open
result = self._call_chain(self.handle_open, protocol, protocol +
'_open', req)
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 464, in _call_chain
result = func(*args)
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 1350, in http_open
return self.do_open(http.client.HTTPConnection, req)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 1324, in do_open
raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 61] Connection refused>
======================================================================
ERROR: test_proxy_with_no_password_raises_httperror (test.test_urllib2_localnet.ProxyAuthTests.test_proxy_with_no_password_raises_httperror)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 1321, in do_open
h.request(req.get_method(), req.selector, req.data, headers,
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
encode_chunked=req.has_header('Transfer-encoding'))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1342, in request
self._send_request(method, url, body, headers, encode_chunked)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1388, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1337, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1097, in _send_output
self.send(msg)
~~~~~~~~~^^^^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1041, in send
self.connect()
~~~~~~~~~~~~^^
File "/Users/hyi/prs/cpython/Lib/http/client.py", line 1007, in connect
self.sock = self._create_connection(
~~~~~~~~~~~~~~~~~~~~~~~^
(self.host,self.port), self.timeout, self.source_address)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/socket.py", line 879, in create_connection
raise exceptions[0]
File "/Users/hyi/prs/cpython/Lib/socket.py", line 864, in create_connection
sock.connect(sa)
~~~~~~~~~~~~^^^^
ConnectionRefusedError: [Errno 61] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/hyi/prs/cpython/Lib/test/test_urllib2_localnet.py", line 374, in test_proxy_with_no_password_raises_httperror
self.opener.open(self.URL)
~~~~~~~~~~~~~~~~^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 487, in open
response = self._open(req, data)
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 504, in _open
result = self._call_chain(self.handle_open, protocol, protocol +
'_open', req)
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 464, in _call_chain
result = func(*args)
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 1350, in http_open
return self.do_open(http.client.HTTPConnection, req)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/hyi/prs/cpython/Lib/urllib/request.py", line 1324, in do_open
raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 61] Connection refused>
----------------------------------------------------------------------
Ran 3 tests in 0.311s
FAILED (errors=3)
test test_urllib2_localnet failed
CPython versions tested on:
CPython main branch
Operating systems tested on:
macOS
Linked PRs
- gh-137943
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Hướng nghiên cứu
Bắt đầu với Lib/test/test_urllib2_localnet.py và các lỗi ProxyAuthTests được nêu trong báo cáo; kiểm tra PR gh-137943 được liên kết để xem công việc đang được thực hiện. Xác nhận rằng các bài kiểm thử proxy hoàn tất thành công trên macOS khi chạy make test.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- python
- Lĩnh vực
- networking, testing-qa
- Loại issue
- Lỗi
- Độ khó
- 3/5
- Thời gian dự kiến
- 1-2 ngày
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 25/100