python / python/cpython

ZipFile.writestr doesn't behave like Path.write_*

未关闭
#134,383 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

stdlib type-feature
主要语言
Python
星标
77.2k
派生
35.9k
PR 合并指标
PR 指标待抓取

描述

Feature or enhancement

Proposal:

Given that ZipPath doesn't provide a write_text or write_bytes, I'm trying to use ZipFile.writestr and noticed that when the data you're trying to write isn't the right type it still stores an empty entry. I didn't expect side effects when it failed this fundamentally to get the data.

import zipfile
with zipfile.ZipFile("foo.zip", "w") as z:
  z.writestr("x", ())
  print(z.namelist()) # -> "x"

Notably, Path.write_text behaves the way I'd expect -- it has to construct a memoryview successfully first before opening the file.

from pathlib import Path
Path("x").write_bytes(()) # -> neither creates nor truncates

@jaraco I assume ZipPath not supporting writes is intentional?

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

该 issue 未指定实现文件或测试。首先复现 zipfile.ZipFile.writestr 示例,并针对无效数据将其与 pathlib.Path.write_bytes 进行比较;检查标准库中相关的实现和测试。完成的标准是:无效输入会引发错误,但不会创建或截断归档条目。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
backend
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。