ZipFile.writestr doesn't behave like Path.write_*

Feature or enhancement

Proposal:

Given that ZipPath doesn't provide a write_text or write_bytes, I'm trying to use ZipFile.writestr and noticed that when the data you're trying to write isn't the right type it still stores an empty entry. I didn't expect side effects when it failed this fundamentally to get the data.

import zipfile
with zipfile.ZipFile("foo.zip", "w") as z:
  z.writestr("x", ())
  print(z.namelist()) # -> "x"

Notably, Path.write_text behaves the way I'd expect -- it has to construct a memoryview successfully first before opening the file.

from pathlib import Path
Path("x").write_bytes(()) # -> neither creates nor truncates

@jaraco I assume ZipPath not supporting writes is intentional?

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

L’issue ne nomme aucun fichier d’implémentation ni aucun test. Commencez par reproduire l’exemple de zipfile.ZipFile.writestr et le comparer à pathlib.Path.write_bytes avec des données invalides ; examinez l’implémentation et les tests pertinents de la bibliothèque standard. Le travail est terminé lorsqu’une entrée invalide lève une erreur sans créer ni tronquer l’entrée de l’archive.