Clarify what to override when subclassing random.Random
未關閉
@tim-one 已經在處理了。
開始於 2025年3月18日。
stdlib
type-bug
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Documentation
In current documentation about the random.Random class, it said that overriding getrandbits() is optional, so it may make people think just overriding random() is sufficient to control the behavior of the class. But in practice methods like randbytes use getrandbits, which is implemented in C to get randomness from MT19937. So it has the following behavior:
import random
class CustomRand(random.Random):
def random(self):
print("CustomRand.random()") # does not get called
return 0.5
myrand = CustomRand()
myrand.seed(123) # just for demonstrating that randbytes still use MT19937
r1 = myrand.randbytes(4)
random.seed(123)
r2 = random.randbytes(4)
print(r1 == r2) # True
Which shows that overriding random() only is not sufficient. From the issue #84466, this seems to be the expected behavior (or not?). So I think this should be documented that overriding getrandbits() is not optional.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
評估
這個 Issue 還沒有評估資料。