Clarify what to override when subclassing random.Random
未关闭
@tim-one 已经在做这个了。
开始于 2025年3月18日。
stdlib
type-bug
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 36k
- PR 合并指标
- PR 指标待抓取
描述
Documentation
In current documentation about the random.Random class, it said that overriding getrandbits() is optional, so it may make people think just overriding random() is sufficient to control the behavior of the class. But in practice methods like randbytes use getrandbits, which is implemented in C to get randomness from MT19937. So it has the following behavior:
import random
class CustomRand(random.Random):
def random(self):
print("CustomRand.random()") # does not get called
return 0.5
myrand = CustomRand()
myrand.seed(123) # just for demonstrating that randbytes still use MT19937
r1 = myrand.randbytes(4)
random.seed(123)
r2 = random.randbytes(4)
print(r1 == r2) # True
Which shows that overriding random() only is not sufficient. From the issue #84466, this seems to be the expected behavior (or not?). So I think this should be documented that overriding getrandbits() is not optional.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。