Unittest.mock.patch - record result of wrapped function call
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Feature or enhancement
Proposal:
I would like to access the return value of a function call wrapped with unittest.mock.patch, that I don't call myself directly.
Motivation
Let's say I have a framework that supports some "before" hooks to allow users to customize some data flowing through the framework.
One could write hook functions for such a framework and publish them.
When doing so, it would make integration tests easier if one could access the return value of a function wrapped with a MagicMock.
# framework.py
def init(before_hook):
... # register the update hook that is later used before doing some action to allow customization of the action
# my_plugin.py
def my_before_hook(some_data: dict) -> dict:
... #do something with some_data eg adding a key
some_data["foo"] = "bar"
return some_data # return the altered data
# test_my_plugin.py
import my_plugin
import framework
def test_my_before_hook():
with unittest.mock.patch("my_plugin.my_before_hook", wraps=my_plugin.my_before_hook) as m:
framework.init(before_hook=m)
... #do something that runs the framework
assert m.called
assert ... # assert m's return value has the key "foo" with the value "bar"
Unfortunately, currently the second assert statement is not really possible - at least I couldn't find anything in the docs, debugger, and LLMs just hallucinated on this one 😅.
Alternatives
There are two alternatives I have considered:
- Digging into the framework and finding a mock target - while this would work, it can be quite tedious, especially when the framework is big
- Wrapping the function in question manually - Definitely possible, but seems to introduce an extra step every time this is necessary and moves the assertion to a an odd place:
# test_my_plugin.py
import my_plugin
import framework
def foo(*args, **kwargs)
result = my_plug.my_before_hook(*args, **kwargs)
assert result["foo"] == "bar" # this only works if the framework doesn't handle AssertionErrors
return result
def test_my_before_hook():
with unittest.mock.patch("my_plugin.my_before_hook", wraps=foo) as m:
framework.init(before_hook=m)
... #do something that runs the framework
assert m.called
Proposed Solution
Record the return value of a "wraps" call and make it available on the call tuple.
I know this could be somewhat problematic due to backwards compatibility, but I'm not entirely sure.
I dove a little bit into the source code and don't think it will be too big of a change both in terms of code and functionality - please correct me if I'm wrong.
I'd be happy to contribute if this is enhancement is desired 🙂
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
先閱讀 issue 所描述的 unittest.mock.patch、MagicMock、wraps 和 call tuple 的現有行為,然後檢查相關的 unittest.mock 實作與測試。確定如何在不破壞目前呼叫 API 的情況下公開包裝函式的回傳值。完成的標準是:該行為已完成規格定義與實作,並且已有測試涵蓋包裝呼叫與相容性。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- testing-qa
- Issue 類型
- 功能
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 42/100