Unittest.mock.patch - record result of wrapped function call
Ninguém assumiu esta issue ainda.
- Linguagem predominante
- Python
- Estrelas
- 77.2k
- Forks
- 35.9k
- Métricas de merge de PRs
- Métricas de PR pendentes
Descrição
Feature or enhancement
Proposal:
I would like to access the return value of a function call wrapped with unittest.mock.patch, that I don't call myself directly.
Motivation
Let's say I have a framework that supports some "before" hooks to allow users to customize some data flowing through the framework.
One could write hook functions for such a framework and publish them.
When doing so, it would make integration tests easier if one could access the return value of a function wrapped with a MagicMock.
# framework.py
def init(before_hook):
... # register the update hook that is later used before doing some action to allow customization of the action
# my_plugin.py
def my_before_hook(some_data: dict) -> dict:
... #do something with some_data eg adding a key
some_data["foo"] = "bar"
return some_data # return the altered data
# test_my_plugin.py
import my_plugin
import framework
def test_my_before_hook():
with unittest.mock.patch("my_plugin.my_before_hook", wraps=my_plugin.my_before_hook) as m:
framework.init(before_hook=m)
... #do something that runs the framework
assert m.called
assert ... # assert m's return value has the key "foo" with the value "bar"
Unfortunately, currently the second assert statement is not really possible - at least I couldn't find anything in the docs, debugger, and LLMs just hallucinated on this one 😅.
Alternatives
There are two alternatives I have considered:
- Digging into the framework and finding a mock target - while this would work, it can be quite tedious, especially when the framework is big
- Wrapping the function in question manually - Definitely possible, but seems to introduce an extra step every time this is necessary and moves the assertion to a an odd place:
# test_my_plugin.py
import my_plugin
import framework
def foo(*args, **kwargs)
result = my_plug.my_before_hook(*args, **kwargs)
assert result["foo"] == "bar" # this only works if the framework doesn't handle AssertionErrors
return result
def test_my_before_hook():
with unittest.mock.patch("my_plugin.my_before_hook", wraps=foo) as m:
framework.init(before_hook=m)
... #do something that runs the framework
assert m.called
Proposed Solution
Record the return value of a "wraps" call and make it available on the call tuple.
I know this could be somewhat problematic due to backwards compatibility, but I'm not entirely sure.
I dove a little bit into the source code and don't think it will be too big of a change both in terms of code and functionality - please correct me if I'm wrong.
I'd be happy to contribute if this is enhancement is desired 🙂
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Direção de pesquisa
Comece lendo o comportamento existente de unittest.mock.patch, MagicMock, wraps e tuplas de chamada descrito pela issue e, em seguida, inspecione a implementação e os testes relevantes de unittest.mock. Determine como o valor de retorno de uma função encapsulada poderia ser exposto sem quebrar a API de chamadas atual. Considera-se concluído quando o comportamento estiver especificado, implementado e coberto por testes para chamadas encapsuladas e compatibilidade.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- python
- Domínio
- testing-qa
- Tipo de issue
- Funcionalidade
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Status de atividade
- Estagnada
- Clareza
- Razoavelmente clara
- Facilidade para iniciantes
- 42/100