resurrected asyncio `_SelectorTransport` unregisters fds it doesn't own
Chưa có ai nhận issue này.
- Ngôn ngữ chính
- Python
- Star
- 77.2k
- Fork
- 36k
- Chỉ số merge pull request
- Chỉ số pull request đang chờ
Mô tả
Bug report
Bug description:
Short story:
- Socket is closed in
_SelectorTransport.__del__, so it doesn't own the fd anymore. - Anything else in the process can create a new file descriptor at this point.
- If the transport is gc-resurrected to call
close(), it can then remove the reader/writer fromloop._selectorhere or here for a fd it doesn't control anymore, causing access to that fd to hang.
Long story:
- Introduce a GC cycle, such that an
asyncio.selector_events._SelectorTransportand the object owning it are collected at the same time. - The transport
__del__will be called, closing the socket, freeing its file descriptor, but not performing any other cleanup. - The owning object, being a good citizen, resurrects the transport during gc to have
close()called on it properly. In the case of this issue, an asyncio task was created to close it later. (I definitely don't love seeingasyncio.create_taskin a__del__method, but I expect that's not the only way to trigger this) - At this point, anything in your asyncio runloop can open a file descriptor. In my case, it was
asyncio.create_subprocess_execcallingos.pidfd_create()inPidfdChildWatcher.add_child_handler. If you're lucky (or running a lot of tasks at once), the new fd will be the same as the resurrected socket's fd. - Now
transport.close()can run any time later, which will callloop._selector.remove_child_watcher(fd), despite not really owning the fd anymore. - Now the pidfd has been removed from
loop._selector, soawait proc.wait()will hang forever. Or whatever asyncio stream you were trying to use got removed from the selector and you won't be able to wait on it.
I definitely think the non-stdlib code in play here was unsound, but I don't think that should trigger such a cursed result in the stdlib, so I'd rather defend against this in asyncio.
I think this is the minimum patch to mitigate the issue, to prevent the remove_child_reader and remove_child_writer calls by breaking their pre-conditions. I'm not sure if it's worth trying to interact with the loop or selector from __del__ to clean up the fd. (Selecting on a missing fd is probably handled somewhere else anyway?)
--- a/Lib/asyncio/selector_events.py
+++ b/Lib/asyncio/selector_events.py
@@ -871,6 +871,8 @@ def close(self):
def __del__(self, _warn=warnings.warn):
if self._sock is not None:
_warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
+ self._closing = True
+ self._buffer.clear()
self._sock.close()
if self._server is not None:
self._server._detach(self)
Another consideration is that asyncio is using a cached self._sock_fd here without really knowing if the underlying socket was closed and fd was recycled or not. I think this isn't the first time the cached fd has caused a surprising behavior, see also https://github.com/python/cpython/issues/88968
CPython versions tested on:
3.12
Operating systems tested on:
Linux
Linked PRs
- gh-130142
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Hướng nghiên cứu
Bắt đầu bằng cách đọc các đường dẫn dọn dẹp của _SelectorTransport trong Lib/asyncio/selector_events.py, đặc biệt là close() và __del__, cùng với issue liên quan về FD được lưu trong bộ nhớ đệm #88968. Tái hiện kịch bản tái sử dụng FD được mô tả trong báo cáo và xác minh rằng một transport được hồi sinh không còn hủy đăng ký một descriptor đã được tái sử dụng khỏi selector nữa.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- python
- Lĩnh vực
- networking
- Loại issue
- Lỗi
- Độ khó
- 4/5
- Thời gian dự kiến
- 3-5 ngày
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 35/100