Promote _delete member of TemporaryDirectory to delete
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 35.9k
- PR 合併指標
- PR 指標待擷取
描述
Feature or enhancement
Proposal:
TemporaryDirectory.__delete__ gained a delete parameter to support retaining temporary files for diagnostic purposes.
In a running system, you may wish gather diagnostic files on failure, or when a specific signal is received. Supporting this fully requires allowing the decision of whether to delete files to be made after the TemporaryDirectory has been __enter__ed.
Assigning to _delete can achieve this effect, but _delete is not part of the public interface.
Therefore, I propose changing TemporaryDirectory._delete to TemporaryDirectory.delete.
Example use to retain temporary files on error:
with TemporaryDirectory() as temp_dir:
try:
thing_that_may_raise()
except Exception:
temp_dir.delete = False
raise
Alternatives considered:
- Provide a function to control this behaviour
- We can always turn
deleteinto a property if necessary
- We can always turn
- Users can provide subclasses of TemporaryDirectory to achieve this
- Temporary Directory doesn't have enough of a public API for this to be viable. Using the private API would be morally equivalent to modifying
_delete, and modifying_deletewould be easier.
- Temporary Directory doesn't have enough of a public API for this to be viable. Using the private API would be morally equivalent to modifying
- Users can provide a wrapper to prevent
__exit__from being called__del__might be implemented in the future, as it is forTemporaryFile.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
- gh-128643
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 TemporaryDirectory 及其 enter/exit 生命週期開始,重點關注進入內容脈絡後刪除決策如何儲存和使用。查看連結的 PR gh-128643,了解已在進行的工作;完成的標準是公開的 delete 屬性支援在 enter 之後變更清理行為。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- operating-systems
- Issue 類型
- 功能
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 25/100