Promote _delete member of TemporaryDirectory to delete
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Python
- Sterne
- 77.2k
- Forks
- 35.9k
- PR-Merge-Kennzahlen
- PR-Kennzahlen ausstehend
Beschreibung
Feature or enhancement
Proposal:
TemporaryDirectory.__delete__ gained a delete parameter to support retaining temporary files for diagnostic purposes.
In a running system, you may wish gather diagnostic files on failure, or when a specific signal is received. Supporting this fully requires allowing the decision of whether to delete files to be made after the TemporaryDirectory has been __enter__ed.
Assigning to _delete can achieve this effect, but _delete is not part of the public interface.
Therefore, I propose changing TemporaryDirectory._delete to TemporaryDirectory.delete.
Example use to retain temporary files on error:
with TemporaryDirectory() as temp_dir:
try:
thing_that_may_raise()
except Exception:
temp_dir.delete = False
raise
Alternatives considered:
- Provide a function to control this behaviour
- We can always turn
deleteinto a property if necessary
- We can always turn
- Users can provide subclasses of TemporaryDirectory to achieve this
- Temporary Directory doesn't have enough of a public API for this to be viable. Using the private API would be morally equivalent to modifying
_delete, and modifying_deletewould be easier.
- Temporary Directory doesn't have enough of a public API for this to be viable. Using the private API would be morally equivalent to modifying
- Users can provide a wrapper to prevent
__exit__from being called__del__might be implemented in the future, as it is forTemporaryFile.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
- gh-128643
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit TemporaryDirectory und seinem enter/exit-Lebenszyklus und konzentriere dich darauf, wie die Löschentscheidung nach dem Eintritt in den Kontext gespeichert und verwendet wird. Sieh dir den verlinkten PR gh-128643 an, um die bereits laufenden Arbeiten zu prüfen; abgeschlossen ist die Aufgabe, wenn das öffentliche delete-Attribut das Ändern des Bereinigungsverhaltens nach enter unterstützt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- operating-systems
- Issue-Typ
- Feature
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 25/100