Removing unncessary class states in bdb.Breakpoint
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 77.2k
- Forks
- 35.9k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Feature or enhancement
Proposal:
According to the comment in the Breakpoint class
Keeping state in the class is a mistake -- this means you cannot have more than one active Bdb instance.
I can support this idea further. Currently, Breakpoint has three class states, next, bplist, and bpbynumber.
class Breakpoint:
...
next = 1
bplist = {}
bpbynumber = [None]
These states are used to enable the reuse of previously set breakpoint instances across multiple interactive sessions or other use cases. However, relying on class states is not the only way to achieve this goal.
Using class states in this case has several clear limitations. As noted in the comment, it makes it difficult to maintain more than one active Bdb instance. Additionally, logic dependent on class state can make the behavior of a new Bdb instance unpredictable in many scenarios unless the exact states of Breakpoint is fully known. Another drawback of maintaining states in the Breakpoint class is that it tightly couples the behavior of all Bdb instances. For example, the deleteMe method must be called periodically by a Bdb instance to ensure the Breakpoint class remains in a valid state.
# example deleteMe calls in Bdb methods
class Bdb:
...
def clear_break(self, filename, lineno):
...
for bp in Breakpoint.bplist[filename, lineno][:]:
bp.deleteMe() # here
self._prune_breaks(filename, lineno)
return None
def clear_bpbynumber(self, arg):
...
try:
bp = self.get_bpbynumber(arg)
except ValueError as err:
return str(err)
bp.deleteMe() # here
self._prune_breaks(bp.file, bp.line)
return None
As an alternative, instance-level state can be maintained within Bdb or derived classes such as Pdb, allowing each instance to manage its own breakpoint data independently. This approach can still support the reuse of previously set breakpoint instances across multiple interactive sessions.
Has this already been discussed elsewhere?
No response given
Links to previous discussion of this feature:
No response
Linked PRs
- gh-127410
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con Lib/bdb.py, especialmente con la clase Breakpoint y los métodos de Bdb mostrados en el issue, y después revisa el PR vinculado gh-127410. Determina cómo se comparte actualmente el estado de los breakpoints entre las instancias de Bdb y cómo afectaría a Bdb y Pdb la propiedad propuesta a nivel de instancia. Se considera terminado cuando el diseño admite instancias de depurador activas e independientes sin depender del estado compartido de la clase Breakpoint.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- devtools
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 20/100