Pass opaque state to PyContext_AddWatcher callback
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 35.9k
- PR 合併指標
- PR 指標待擷取
描述
Feature or enhancement
Proposal:
I would like to change the Context watcher C API (new to v3.14, see #119333) to pass an opaque pointer to the callback. Specifically, change:
to:
/*
* Context object watcher callback function. arg is the same pointer passed to
* PyContext_AddWatcher when the callback was registered. The object passed to
* the callback is event-specific; see PyContextEvent for details.
*
* if the callback returns with an exception set, it must return -1. Otherwise
* it should return 0
*/
typedef int PyContext_WatchCallback(
void *arg, PyContextEvent event, PyObject *obj);
/*
* Register a per-interpreter callback that will be invoked for context events.
* arg is an optional opaque pointer that is passed back to the callback; it
* can be used to manage state if desired.
*
* Returns a handle that may be passed to PyContext_ClearWatcher on success,
* or -1 and sets and error if no more handles are available.
*/
PyAPI_FUNC(int) PyContext_AddWatcher(
PyContext_WatchCallback *callback, void *arg);
The original idea was for the callback to get any required state from the current context, but:
- The config/state is not guaranteed to be available in the context. For example, the Python code can do
ctx = contextvars.Context()instead ofctx = contextvars.copy_context(). Or it can docopy_context(), but early during initialization and squirrel the context away for later use. The latter seems plausible for 3rd party libraries (where the user might not have much control). - The same watcher callback cannot be registered multiple times simultaneously, each with its own config/state. This came up while I was refactoring
TestContextObjectWatchersto add some more tests for a change I’m working on.
I’m not sure how likely either is to come up in normal use, but I think it is worth changing the design before the 3.14 release cements it.
Has this already been discussed elsewhere?
I have already discussed this feature proposal on Discourse
Links to previous discussion of this feature:
https://discuss.python.org/t/v3-14a1-design-limitations-of-pycontext-addwatcher/68177/4
cc @fried
Linked PRs
- gh-127140
- gh-127247
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 Include/cpython/context.h 中的 Context watcher 宣告開始,檢查 Lib/test/test_capi/test_watchers.py,尤其是 TestContextObjectWatchers。在開始之前檢查連結的 PR,然後驗證已註冊的 opaque pointer 能夠傳遞到 callback,並且 watcher 測試涵蓋更新後的 API 且通過。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- c, python
- 領域
- api
- Issue 類型
- 功能
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 描述清楚
- 新手友好度
- 30/100